patch for bug 27362 : put redirected URLs in history

[Carsten Pfeiffer]

-----BEGIN PGP SIGNED MESSAGE-----

On Wednesday 24 July 2002 01:08, Con Hennessy wrote:

[Konqueror issues are handled on kfm-devel]

Hi,

> The bug http://bugs.kde.org/db/27/27362.html is marked as a duplicate
> and is closed. However I could not find any other bug which may be a
> duplicate of it, also the problem itself is not resolved.
>
> Basically the problem is that when a URL is actually redirected,
> this URL is never added to the history, and therefore is never
> marked as being "visited" when you go back to the original page.
> As an example following any news link from http://newshub.com/tech
> or any link from http://www.freshmeat.net/.
>
> The patch files below, are very basic :
> 1) to the class BrowserRun a slotRedirection slot is added and
>    connected with the redirection signal from the KIO::TransferJob;
> 2) to the class KonqRun the virtual method defined above (slotRedirection)
>    is redefined so that the pending URL ( i.e. the one which we are
>    being redirected from ) is confirmed and the new URL ( i.e. the
>    one we are being directed to ) is added as "pending".
>
> These changes work for me (on newshub but now I'm not completely sure
> whether they do on freshmeat ?). I am not sure if KonqRun is the right
> class to add the code for the history.

Thanks for the patch! Unfortunately, it causes a binary incompatibility in 
KParts::BrowserRun (we can't add a new virtual method). However, looking at 
BrowserRun::scanFile(), the job is assigned to KRun's m_job, so KonqRun could 
simply reimplement scanFile(), call BrowserRun::scanFile and then connect() 
to the redirected() signal.

New patch attached. Unfortunately, David Faure is on vacation at the moment, 
so it might take a little while to get his comment.

Cheers
Carsten Pfeiffer
-----BEGIN PGP SIGNATURE-----

iQEVAwUBPT+AwqWgYMJuwmZtAQH0LQf+LfJ93xyurdQzs1Y3GNlLQiIO9jo13dga
o9bxBx1UlSoiiztVeTVsSm2Sk8bMS/fXpYpIHYc3FQvHCpoE1F24JWuCMgug9Mo6
RnNdDKH/vsxHVYB0+8LW9hbjyMs7mXRfpoK6jkDz/tQufv/v8c9nsmkCcHMQDMD4
mRt9E6kPkqndG5BTYKDW0VMvHcEY+myNj/WFxGfCj6zNRGWolVDAro7CEPqLp67Z
lH2Ws0eZKs3dJaHg5X0c2ambCGwJuy7c/6ka8z2y2LSooxWt9yNNbFTH8ipbQb73
HHlLDOcFCyzD4vnf3IAB+uQK51dx+pFNaB81T9MSUU3NF0NtUdqAaQ==
=3NxD
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch
Type: text/x-diff
Size: 2030 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20020725/053d9dae/attachment.diff>