Is someone working on #41620 ?

[David Faure]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Friday 19 July 2002 13:00, Germain Garand wrote:
> Le Jeudi 18 Juillet 2002 15:33, David Faure a écrit :
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Please test this patch with as many combinations as possible:
> >
> 
> Hi David,
> I've got two more observations since yesterday :
> 
> 1) bool KHTMLPart::processObjectRequest() should be in sync with this change, 
> since that's what is used to create parts in frames (see BR#43393)
> (same "if" test on mimetype at khtml_part.cpp -l.2664)

One can't ask for another viewer than the preferred one, in khtml.
Ah, but if the current viewer handles the new mimetype but isn't preferred.... I see.
Ok, please test attached patch.

> 2) What about the case where the new mimetype is different, but the preferred 
> part for the new mimetype finally proves to be the same as the current one ?
> e.g: you display a "text/plain" file, then a "text/css" file... 
> 
> /me think konqueror should then reuse the current view, instead of creating a 
> new one of the same kind ?

You are very right!
Please test attached patch for konq_view too ;) 
(I'm busy with so many other things right now....)

Ah, a similar test for KHTML is missing. A bit harder. I think we need to pass
the current serviceName to createPart so that it skips creating a new part if
the old one is of the same service. Hmm, to be checked.

- -- 
David FAURE, david at mandrakesoft.com, faure at kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
On holidays from 20/07 to 24/07
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE9OEq672KcVAmwbhARAi/6AJ9A7rxi1KxP64abRmtYhjxD6oe2jwCglHeg
5jbzBqE7v8p9LjZR9nwXFx8=
=7BJ7
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: konq_view.cc.diff
Type: text/x-diff
Size: 2432 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20020719/d83364a7/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: khtml_part.cpp.diff
Type: text/x-diff
Size: 769 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20020719/d83364a7/attachment-0001.diff>