Is someone working on #41620 ?

[David Faure]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Thursday 18 July 2002 16:25, Germain Garand wrote:
> Le Jeudi 18 Juillet 2002 14:46, David Faure a écrit :
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > On Thursday 18 July 2002 13:56, Germain Garand wrote:
> > > This is a very important one... that is : if a konqueror view switches to
> > > text mode, it never goes back... even if you span new tabs !
> > >
> > > For instance, try to view those CSS:
> > > http://www.phoenix-library.org/phoenix.css
> > >
> > > Then manually correct the URL to go back to root (or hit the "up"
> > > button)... Yep. HTML is now displayed as text. As well as any subsequent
> > > URL.
> >
> > The kate part handles this mimetype, so it gets reused for it.
> > See previous discussions.
> > We can't solve this in a generic way, since the generic way is correct
> > (reuse current part if it handles the given mimetype).
> 
> Though, there's a preference order about what part is linked to what 
> mimetype...
> If what lead to the invocation of the current part is a given mimetype, it's 
> fine to keep it if we are given the *same* mimetype for the following 
> document.
> But, IMO, if the mimetype differ, the correct behaviour should be to check 
> what's the preferred viewer for this new mimetype ...
> Just a thought.

That makes sense !!! Finally a sensible solution for this problem ;)

Please test this patch with as many combinations as possible:

Index: konq_view.cc
===================================================================
RCS file: /home/kde/kdebase/konqueror/konq_view.cc,v
retrieving revision 1.305
diff -u -p -r1.305 konq_view.cc
- --- konq_view.cc        2002/07/05 23:24:04     1.305
+++ konq_view.cc        2002/07/18 14:32:25
@@ -254,7 +254,7 @@ bool KonqView::changeViewMode( const QSt
                 << " serviceName is " << serviceName
                 << " current service name is " << m_service->desktopEntryName() << endl;

- -  if ( !m_service->serviceTypes().contains( serviceType ) ||
+  if ( m_serviceType != serviceType ||
        ( !serviceName.isEmpty() && serviceName != m_service->desktopEntryName() ) )
   {

@@ -291,15 +291,6 @@ bool KonqView::changeViewMode( const QSt
     // where the location bar url isn't set yet.
     kdDebug(1202) << "Giving focus to new part " << m_pPart << endl;
     m_pMainWindow->viewManager()->setActivePart( m_pPart );
- -  }
- -  else if ( m_serviceType != serviceType )
- -  {
- -      m_serviceType = serviceType;
- -      kdDebug(1202) << "KonqView::changeViewMode service type set to " << m_serviceType << endl;
- -      // Re-query the trader
- -      KonqFactory::getOffers( m_serviceType, &m_partServiceOffers, &m_appServiceOffers );
- -      if ( m_pMainWindow->currentView() == this )
- -          m_pMainWindow->updateViewModeActions();
   }
   return true;
 }


- -- 
David FAURE, david at mandrakesoft.com, faure at kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
KOffice-1.2-beta2 is out! http://dot.kde.org/1025176121/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE9NtGw72KcVAmwbhARAmSfAJsGofDhcbH+zZfhclZEPLxGK8DqgACgl/4t
Wxxewde1vUPXi8GxQk0uuqE=
=+mcF
-----END PGP SIGNATURE-----