About khtml/xml/dom2_eventsimpl.cpp revision 1.22

Koos Vriezen koos.vriezen at xs4all.nl
Sat Jul 13 23:21:06 BST 2002


On Sat, 13 Jul 2002, Dirk Mueller wrote:

> No, nothing should be reverted, because it works correctly the way it is. if
> you want it to work better, then  then make sure that
> HTMLAnchorElementImpl::defaultEventHandler
> calls setDefaultEventHandled only when it actually was able to handle
> the keypress and not all the time like it does now.

No, it doesn't

--- html/html_inlineimpl.cpp    2002/03/15 22:53:08     1.109
+++ html/html_inlineimpl.cpp    2002/07/13 22:11:06
@@ -82,6 +82,8 @@ void HTMLAnchorElementImpl::defaultEvent

         if ( k ) {
             if (k->virtKeyVal() != KeyEventImpl::DOM_VK_ENTER) {
+                if (k->qKeyEvent)
+                    k->qKeyEvent->ignore();
                 HTMLElementImpl::defaultEventHandler(evt);
                 return;
             }

It just returned (NodeImpl::defaultEventHandler being empty). Adding these
two lines seems to work (as David suggested).

> For example it could capture space and return, and ignore the rest.

Space? Doesn't do anything now and it's also a scroll key.

Koos





More information about the kfm-devel mailing list