About khtml/xml/dom2_eventsimpl.cpp revision 1.22

[Koos Vriezen]

On Sat, 13 Jul 2002, Dirk Mueller wrote:

> On Sam, 13 Jul 2002, David Faure wrote:
>
> > > This patch makes that the scroll keys don't work when a link has the
> > > focus. Shouldn't XXEdit event handles mark qKeyEvent as accepted?
> >
> > Hmm, I'm no expert on the question, and I don't remember the big
> > picture (if I ever grasped it ;).
> >
> > Anyway from the above comment: we could also state that this default
> > behaviour (accepting) is correct, and that the fix would be for the link
> > to ignore (pass up, whatever) any keyevent it doesn't handle?
> >
> > This needs more investigation, sorry I can't do it today.
>
> The big picture is working around Qt bugs: Qt widgets usually only
> reimplement keydown event, not the keyup event. therefore while some
> subwidget on the page might accept (i.e. capture) a keypress event, the
> keyrelease event still arrives in the khtmlview, and has to be ignored
> there.

Forgive me for being dumb, but you mean version 1.22 should be reverted?
And where to put the accept call, in
HTMLGenericFormElementImpl::defaultEventHandler, other places too?
HTMLAnchorElementImpl::defaultEventHandler already accepts in case of
enter.

Koos