caching-patch V0.2.0

[Waldo Bastian]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Friday 23 August 2002 08:35 am, Tobias Anton wrote:
> Please look over it & comment.
>
> After the weekend, i'd like to apply this patch if no one objects.
>
> It tries to reduce reloads to a minimum, respecting the http headers and
> propagate relative and absolute expire dates from the html page to the
> embedded objects.
>
> Since a relative expire time may change on an already existing
> cachedObject, the creation date of the http cache entry must be stored to
> recalculate the corresponding absolute expire time, which may eventually
> lead to an update of the http cache.

It assumes that when a document with creation time t_doc_create sets a 
relative expire time t_doc_expire that the images with a creation time 
t_img_create should expire on t_img_create+t_doc_expire. 

I think that's wrong and I think the images should expire on 
t_doc_create+t_doc_expire.

I agree that if no cacheCreationDate is specified it should default to a 
sensible value such as time(0), but I would add the logic for that to 
setCacheCreationDate() instead of letting the caller handle it.

Cheers,
Waldo
- -- 
bastian at kde.org  |   SuSE Labs KDE Developer  |  bastian at suse.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE9Z/ZfN4pvrENfboIRAhawAJ9wntfUt4guGgtya6eoCvvGNkQ/EQCfcc/f
NScHEUCb2S8TurmDaTjOXdI=
=QUVW
-----END PGP SIGNATURE-----