About KJS::HTMLCollection::getNamedItems

David Faure david at mandrakesoft.com
Thu Aug 15 14:24:14 BST 2002


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Thursday 15 August 2002 14:15, Koos Vriezen wrote:
> > I think this is really only for forms. The fix would be to add a new value to the ReturnType enum
> > in KJS::HTMLCollection, named "ReturnForm" (i.e. only return form elements),
> > and add support for it in HTMLCollection, and use that value in kjs_html.cpp:169
> > if element.elementId() == ID_FORM.
> 
> That would be great.

Actually this was a wrong approach. Much simpler is to just use the forms
collection (document.forms). Same with images for consistency.
This actually makes the code more sensible than it used to be, so this is good;)

Committed, works for me, please test the website you saw problems on.

- -- 
David FAURE, david at mandrakesoft.com, faure at kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
KOffice-1.2-rc1 is out. ftp://ftp.kde.org/pub/kde/unstable/koffice-1.2-rc1/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE9W6t/72KcVAmwbhARAp0xAJ95ImHtpsNgioZcFq+qb5iJ2H9viwCeIeYb
LO3I8wveUjBnbhnZp/XabTU=
=NJpN
-----END PGP SIGNATURE-----





More information about the kfm-devel mailing list