About KJS::HTMLCollection::getNamedItems

[David Faure]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Thursday 15 August 2002 14:15, Koos Vriezen wrote:
> On Thu, 15 Aug 2002, David Faure wrote:
> 
> > But this doesn't answer the "is this behaviour for forms only, or for all nested elements".
> > Did you try stuff like <div name='test'><div name='test'></div></div>, to
> > see if your idea about identically-named nested elements is true?
> 
> Like I said, I did some small tests and it looks like you're right. If I
> put the text box outside the form or in another form, document.myname
> always comes with the myname form.
Ah, so this confirms it's not related to nesting, I see. Good.

> > I think this is really only for forms. The fix would be to add a new value to the ReturnType enum
> > in KJS::HTMLCollection, named "ReturnForm" (i.e. only return form elements),
> > and add support for it in HTMLCollection, and use that value in kjs_html.cpp:169
> > if element.elementId() == ID_FORM.
> 
> That would be great.
Ok, will do then ;)

> Could you also do something about the default value
> of this collection in case there are multible elements? (Harri doesn't
> like my idea. Damn, just made a patch for it.)

I just fixed it the right way - DOMNamedNodesMap was lacking a ClassInfo
and more importantly it didn't have the 'object prototype' set.

- -- 
David FAURE, david at mandrakesoft.com, faure at kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
KOffice-1.2-rc1 is out. ftp://ftp.kde.org/pub/kde/unstable/koffice-1.2-rc1/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE9W5/c72KcVAmwbhARAgz+AJ0dqRPCZZehJwespJdyBP+ON6QSnACeNSux
KugkQx8ph0s3NSVlrozkYcw=
=E1jT
-----END PGP SIGNATURE-----