D29327: Improve a bit parse error dignosis

[Jarosław Staniek]

staniek requested changes to this revision.
staniek added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> jfita wrote in KDbSqlScanner.l:155
> BEGIN is to switch to a new start condition: after this flex will only look for rules that are within the group DATE_OR_TIME_caller, in this case the INITIAL or empty start condition.  That is, it will look all the rules that have *no* prefix, hence this is the end of the date/time “subparser”.
> 
> In other words, this is the rule of the '#' character that ends the date/time literal.

Thanks

> KDbSqlScanner.l:164
> +    ECOUNT;
> +    setError(KDbParser::tr("Unexpected character in date time literal: %1").arg(yytext[0]));
> +    return SCAN_ERROR;

Something easier to translate and understand for end users would be better. E.g.

"Unexpected character \"%1\" in date/time"

> sqlscanner.cpp:1452
> +    ECOUNT;
> +    setError(KDbParser::tr("Unexpected character in input: %1").arg(yytext[0]));
> +    return SCAN_ERROR;

"Unexpected character \"%1\""

would be more consistent

REPOSITORY
  R15 KDb

REVISION DETAIL
  https://phabricator.kde.org/D29327

To: jfita, staniek, piggz
Cc: Kexi-Devel-list, barman, wicik, staniek
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kexi-devel/attachments/20200502/50197fd9/attachment.html>