D29277: Escape table name in when building a select statement with row id

[jordi fita i mas]

jfita added a comment.


  In D29277#659787 <https://phabricator.kde.org/D29277#659787>, @staniek wrote:
  
  > Thanks. Is there any relation to https://bugs.kde.org/show_bug.cgi?id=420599?
  
  
  Yes, this is related to both https://bugs.kde.org/show_bug.cgi?id=420599 and https://bugs.kde.org/show_bug.cgi?id=332161 .
  
  In D29277#659798 <https://phabricator.kde.org/D29277#659798>, @staniek wrote:
  
  > To be sure, you're constructing a query using C++ classes and not using the parser? 
  >  I am asking because to me "select id from [table]" does not work since we do not (yet) support identifier escaping with [].
  
  
  I modified KDb in my local machine to accept quoted identifiers using back quotes (this is related to the comment i just posted to https://bugs.kde.org/show_bug.cgi?id=332161) and i was trying it out with an unmodified version of Kexi, to see what issues it raises.  Thus i saw the problem this commit fixes using the parser through Kexi, but i assumed that it would be the same using C++ to construct the query, that is why i sent the fix. Also, it //will// be a problem once KDb has quoted identifiers.
  
  I understand this makes it hard for you to test the changes, though.

REPOSITORY
  R15 KDb

REVISION DETAIL
  https://phabricator.kde.org/D29277

To: jfita, staniek, piggz
Cc: Kexi-Devel-list, barman, wicik, staniek
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kexi-devel/attachments/20200429/f015437a/attachment.html>