<table><tr><td style="">jfita added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29277">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D29277#659787" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D29277#659787</a>, <a href="https://phabricator.kde.org/p/staniek/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@staniek</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Thanks. Is there any relation to <a href="https://bugs.kde.org/show_bug.cgi?id=420599" class="remarkup-link" target="_blank" rel="noreferrer">https://bugs.kde.org/show_bug.cgi?id=420599</a>?</p></div>
</blockquote>
<p>Yes, this is related to both <a href="https://bugs.kde.org/show_bug.cgi?id=420599" class="remarkup-link" target="_blank" rel="noreferrer">https://bugs.kde.org/show_bug.cgi?id=420599</a> and <a href="https://bugs.kde.org/show_bug.cgi?id=332161" class="remarkup-link" target="_blank" rel="noreferrer">https://bugs.kde.org/show_bug.cgi?id=332161</a> .</p>
<blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D29277#659798" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D29277#659798</a>, <a href="https://phabricator.kde.org/p/staniek/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@staniek</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>To be sure, you're constructing a query using C++ classes and not using the parser? <br />
I am asking because to me "select id from [table]" does not work since we do not (yet) support identifier escaping with [].</p></div>
</blockquote>
<p>I modified KDb in my local machine to accept quoted identifiers using back quotes (this is related to the comment i just posted to <a href="https://bugs.kde.org/show_bug.cgi?id=332161" class="remarkup-link" target="_blank" rel="noreferrer">https://bugs.kde.org/show_bug.cgi?id=332161</a>) and i was trying it out with an unmodified version of Kexi, to see what issues it raises. Thus i saw the problem this commit fixes using the parser through Kexi, but i assumed that it would be the same using C++ to construct the query, that is why i sent the fix. Also, it <em>will</em> be a problem once KDb has quoted identifiers.</p>
<p>I understand this makes it hard for you to test the changes, though.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R15 KDb</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29277">https://phabricator.kde.org/D29277</a></div></div><br /><div><strong>To: </strong>jfita, staniek, piggz<br /><strong>Cc: </strong>Kexi-Devel-list, barman, wicik, staniek<br /></div>