D17887: Fix detection of .kexi file types after recent change of mime database on Linux for SQLite type (2018-06-17)

[Jarosław Staniek]

staniek marked an inline comment as done.
staniek added a comment.


  In D17887#384770 <https://phabricator.kde.org/D17887#384770>, @pino wrote:
  
  > I don't understand what is tested in `KDbTestUtils::testDriver()` now, related to the mimetypes. The old logic looked better (and simpler too) to me, I'd just leave that.
  >  The only simple addition IMHO is that `manager.driverIdsForMimeType(mimeName)` returns a valid driver for each of the mimetypes specified in the plugin metadata.
  
  
  Two things:
  
  - the original logic of the patch completely missed checks of driverIdsForMimeType(), it is also not present in 3.2 branch
  - the issue with invalid mimetypes on testing OS
  
  > Also, the commit message needs to be updated to just say that mimetypes are always resolved in the driver manager, so even if a mimetype claimed by a driver becomes an alias the plugin is still loaded.
  
  It's good idea for the API docs, I'll add.

REPOSITORY
  R15 KDb

REVISION DETAIL
  https://phabricator.kde.org/D17887

To: staniek, piggz, pino
Cc: pino, Kexi-Devel-list, barman, wicik, staniek
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kexi-devel/attachments/20190101/4bd282f7/attachment.html>