D9941: Simplify handling item-data-source property in elements

[Jarosław Staniek]

staniek added a comment.


  Thanks for the reminder Adam.
  
  1. Now I wonder if there's room for a cleanup before we release. Is the '$' prefix used (documented) somewhere?
  
  We have `KProperty("value", QString(), tr("Value"), tr("Value used if not bound to a field"))` IIRC per my request long ago to simplify the logic.
  Special cases: it's called "static-image" for images for backward-compatibility, and for maps we have 3 properties long/lat/zoom.
  
  What do you think about removing the support for the '$' prefix?
  If we no longer have the prefix we do not worry about it having no sense e.g. for image elements.
  
  2. The '=' prefix. Looks like it's working, has no equivalent elsewhere in reports and has users already.
  
  Do you see any reason why we would not support the '=' for element types that were not supported before?
  That is, for image, text, barcode, maps, web. This patch currently does it.
  
  PS: Maybe in the future we would display invalid column names in some special way on the report. That is, as long as we don't support the '$' prefix, datasource string not having '=' prefix and not leading to existing field is an error worth emphasizing.

REPOSITORY
  R14 KReport

REVISION DETAIL
  https://phabricator.kde.org/D9941

To: staniek, piggz
Cc: Kexi-Devel-list, staniek
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kexi-devel/attachments/20180118/9b364ba7/attachment.html>