<table><tr><td style="">staniek added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9941" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Thanks for the reminder Adam.</p>
<ol class="remarkup-list">
<li class="remarkup-list-item">Now I wonder if there's room for a cleanup before we release. Is the '$' prefix used (documented) somewhere?</li>
</ol>
<p>We have <tt style="background: #ebebeb; font-size: 13px;">KProperty("value", QString(), tr("Value"), tr("Value used if not bound to a field"))</tt> IIRC per my request long ago to simplify the logic.<br />
Special cases: it's called "static-image" for images for backward-compatibility, and for maps we have 3 properties long/lat/zoom.</p>
<p>What do you think about removing the support for the '$' prefix?<br />
If we no longer have the prefix we do not worry about it having no sense e.g. for image elements.</p>
<ol class="remarkup-list" start="2">
<li class="remarkup-list-item">The '=' prefix. Looks like it's working, has no equivalent elsewhere in reports and has users already.</li>
</ol>
<p>Do you see any reason why we would not support the '=' for element types that were not supported before?<br />
That is, for image, text, barcode, maps, web. This patch currently does it.</p>
<p>PS: Maybe in the future we would display invalid column names in some special way on the report. That is, as long as we don't support the '$' prefix, datasource string not having '=' prefix and not leading to existing field is an error worth emphasizing.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R14 KReport</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D9941" rel="noreferrer">https://phabricator.kde.org/D9941</a></div></div><br /><div><strong>To: </strong>staniek, piggz<br /><strong>Cc: </strong>Kexi-Devel-list, staniek<br /></div>