D9941: Simplify handling item-data-source property in elements

Jarosław Staniek noreply at phabricator.kde.org
Wed Jan 17 09:29:40 UTC 2018


staniek created this revision.
staniek added a reviewer: piggz.
Restricted Application added a project: KReport.
staniek requested review of this revision.

REVISION SUMMARY
  They are all the same, let's remove copy-pasted code.
  
  This also makes the property editable for all elements supporting data source, so also completer works there.
  
  FIXED-IN:3.1.0

TEST PLAN
  Try data source properties of elements in KReportExample and KEXI Reports

REPOSITORY
  R14 KReport

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9941

AFFECTED FILES
  src/common/KReportItemBase.cpp
  src/common/KReportItemBase.h
  src/items/check/KReportDesignerItemCheckBox.cpp
  src/items/check/KReportDesignerItemCheckBox.h
  src/items/check/KReportItemCheck.cpp
  src/items/check/KReportItemCheck.h
  src/items/field/KReportDesignerItemField.cpp
  src/items/field/KReportDesignerItemField.h
  src/items/field/KReportItemField.cpp
  src/items/field/KReportItemField.h
  src/items/image/KReportDesignerItemImage.cpp
  src/items/image/KReportDesignerItemImage.h
  src/items/image/KReportItemImage.cpp
  src/items/image/KReportItemImage.h
  src/items/text/KReportDesignerItemText.cpp
  src/items/text/KReportDesignerItemText.h
  src/items/text/KReportItemText.cpp
  src/items/text/KReportItemText.h
  src/items/text/KReportScriptText.cpp
  src/plugins/barcode/KReportDesignerItemBarcode.cpp
  src/plugins/barcode/KReportDesignerItemBarcode.h
  src/plugins/barcode/KReportItemBarcode.cpp
  src/plugins/barcode/KReportItemBarcode.h
  src/plugins/barcode/KReportScriptBarcode.cpp
  src/plugins/chart/KReportDesignerItemChart.cpp
  src/plugins/chart/KReportItemChart.cpp
  src/plugins/chart/KReportItemChart.h
  src/plugins/chart/KReportScriptChart.cpp
  src/plugins/maps/KReportDesignerItemMaps.cpp
  src/plugins/maps/KReportDesignerItemMaps.h
  src/plugins/maps/KReportItemMaps.cpp
  src/plugins/maps/KReportItemMaps.h
  src/plugins/web/KReportDesignerItemWeb.cpp
  src/plugins/web/KReportDesignerItemWeb.h
  src/plugins/web/KReportItemWeb.cpp
  src/plugins/web/KReportItemWeb.h
  src/wrtembed/KReportDesignerItemRectBase.cpp

To: staniek, piggz
Cc: Kexi-Devel-list, staniek
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kexi-devel/attachments/20180117/ba7e6099/attachment.html>


More information about the Kexi-devel mailing list