<table><tr><td style="">staniek created this revision.<br />staniek added a reviewer: piggz.<br />Restricted Application added a project: KReport.<br />staniek requested review of this revision.

</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9941" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>They are all the same, let's remove copy-pasted code.</p>

<p>This also makes the property editable for all elements supporting data source, so also completer works there.</p>

<p>FIXED-IN:3.1.0</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Try data source properties of elements in KReportExample and KEXI Reports</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R14 KReport</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D9941" rel="noreferrer">https://phabricator.kde.org/D9941</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/common/KReportItemBase.cpp<br />

src/common/KReportItemBase.h<br />

src/items/check/KReportDesignerItemCheckBox.cpp<br />

src/items/check/KReportDesignerItemCheckBox.h<br />

src/items/check/KReportItemCheck.cpp<br />

src/items/check/KReportItemCheck.h<br />

src/items/field/KReportDesignerItemField.cpp<br />

src/items/field/KReportDesignerItemField.h<br />

src/items/field/KReportItemField.cpp<br />

src/items/field/KReportItemField.h<br />

src/items/image/KReportDesignerItemImage.cpp<br />

src/items/image/KReportDesignerItemImage.h<br />

src/items/image/KReportItemImage.cpp<br />

src/items/image/KReportItemImage.h<br />

src/items/text/KReportDesignerItemText.cpp<br />

src/items/text/KReportDesignerItemText.h<br />

src/items/text/KReportItemText.cpp<br />

src/items/text/KReportItemText.h<br />

src/items/text/KReportScriptText.cpp<br />

src/plugins/barcode/KReportDesignerItemBarcode.cpp<br />

src/plugins/barcode/KReportDesignerItemBarcode.h<br />

src/plugins/barcode/KReportItemBarcode.cpp<br />

src/plugins/barcode/KReportItemBarcode.h<br />

src/plugins/barcode/KReportScriptBarcode.cpp<br />

src/plugins/chart/KReportDesignerItemChart.cpp<br />

src/plugins/chart/KReportItemChart.cpp<br />

src/plugins/chart/KReportItemChart.h<br />

src/plugins/chart/KReportScriptChart.cpp<br />

src/plugins/maps/KReportDesignerItemMaps.cpp<br />

src/plugins/maps/KReportDesignerItemMaps.h<br />

src/plugins/maps/KReportItemMaps.cpp<br />

src/plugins/maps/KReportItemMaps.h<br />

src/plugins/web/KReportDesignerItemWeb.cpp<br />

src/plugins/web/KReportDesignerItemWeb.h<br />

src/plugins/web/KReportItemWeb.cpp<br />

src/plugins/web/KReportItemWeb.h<br />

src/wrtembed/KReportDesignerItemRectBase.cpp</div></div></div><br /><div><strong>To: </strong>staniek, piggz<br /><strong>Cc: </strong>Kexi-Devel-list, staniek<br /></div>