a cleanup patch for make build and friends

[John Birch]

Hi Roland,

I was going to argue over including this patch, however I quite like it, but, 
as you say, it's not finished and I also don't think it goes far enough.

Things like what directory we will run the make from should be located in 
CProject. And it looks like it's the same with the CFLAGS/CXXFLAGS.

and I didn't know the slotBuildCleanRebuildAll does a UpdateMakefileAm. That 
looks strange (and wrong) to me. Wonder why?

I'm assuming you're going to keep going on this?

jbb

On Thu, 01 Mar 2001 15:40, Roland Krause wrote:
> I have tried to cleanup and follow through some of the SlotMakeBuild
> code on ckdevelop.cpp and ckdevelop.h.
>
> Enclosed is a patch, maybe someone can apply it and tell me what they
> think. The patch introduces a function RunMake that is called from all
> the Slots that have something to do with Building.
>
> It is not a final solution but reduces the code duplication quite a
> little bit.
>
> There are a bunch of things that are really fishy here and one thing
> maybe even wrong. When RunMake is called rerun the Makefile.cvs or
> Makefile.dist it should always run in the projectDir, shouldnt it?
> Hmmm....
>
> This is quite a mess, any good ideas for reorganization of this are
> greatly appreciated.
>
> Regards
> Roland
>
>
>
> =====
> Roland Krause
>
>
>
> __________________________________________________
> Do You Yahoo!?
> Get email at your own domain with Yahoo! Mail.
> http://personal.mail.yahoo.com/

----------------------------------------
Content-Type: application/x-unknown; charset="us-ascii"; 
name="build_make.diff"
Content-Transfer-Encoding: base64
Content-Description: build_make.diff
----------------------------------------

-
to unsubscribe from this list send an email to kdevelop-request at kdevelop.org with the following body:
unsubscribe »your-email-address«