D26254: Add support for PHP 7.4's typed properties

[Hugues Mitonneau]

hmitonneau added a comment.


  The test output:
  
    2: FAIL!  : Php::TestDUChain::classMemberVar() 'var->type<IntegralType>()' returned FALSE. ()
    2:    Loc: [/home/hmitonneau/kde/src/kdev-php/duchain/tests/duchain.cpp(449)]
  
  Here is a better fix:
  
    diff --git a/duchain/builders/typebuilder.cpp b/duchain/builders/typebuilder.cpp
    index 18e6bcb..ccf303b 100644
    --- a/duchain/builders/typebuilder.cpp
    +++ b/duchain/builders/typebuilder.cpp
    @@ -47,6 +47,7 @@ namespace Php
     TypeBuilder::TypeBuilder()
         : TypeBuilderBase()
         , m_gotTypeFromDocComment(false)
    +    , m_gotTypeFromTypeHint(false)
         , m_gotReturnTypeFromDocComment(false)
     {
     }
  
  I'm using gcc 9.2.1:
  
    $ /usr/bin/gcc --version
    gcc (Ubuntu 9.2.1-9ubuntu2) 9.2.1 20191008

REPOSITORY
  R52 KDevelop: PHP Support

REVISION DETAIL
  https://phabricator.kde.org/D26254

To: pprkut
Cc: hmitonneau, kdevelop-devel, christiant, glebaccon, domson, antismap, iodelay, alexeymin, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20200506/09ab53f2/attachment.html>