D19673: Discovered unit-tests using bracket arguments and/or listed in files other than CTestTestFile.cmake

[Milian Wolff]

mwolff accepted this revision.
mwolff added a comment.
This revision is now accepted and ready to land.


  thanks, lgtm - I'll amend the last nits and apply it for you - if you give me full name and email address such that I can set you as the main author of this patch

INLINE COMMENTS

> cmakeutils.cpp:696
>  {
> -    const auto contents = CMakeListsParser::readCMakeFile(buildDir.toLocalFile() + QLatin1String("/CTestTestfile.cmake"));
> -
> +    const auto cmakeTestFile = Path(buildDir, cmakeTestFileName).toLocalFile()  ;
> +    const auto contents = CMakeListsParser::readCMakeFile(cmakeTestFile);

style: remove spaces before;

> cmakeutils.cpp:738
>  
> +QVector<Test> importTestSuites(const Path &buildDir) {
> +    return importTestSuites(buildDir, QStringLiteral("CTestTestfile.cmake"));

style: move { to its own line for function bodies

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D19673

To: tnorth, apol, kfunk, mwolff
Cc: mwolff, kdevelop-devel, gennad, glebaccon, domson, antismap, iodelay, alexeymin, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20190312/ab88f4ab/attachment-0001.html>