D21589: Duplicate Visual Studio 2017 hack for VS 2019

[Petros Siligkounas]

Petross404 added a comment.


  brauch is referring to this
  
    REM load Visual Studio 2017 developer command prompt if VS150COMNTOOLS isn't set. Read Windows registry in case VS is not istalled on C:\  
    IF NOT DEFINED VS160COMNTOOLS (
        REM load Visual Studio 2019 developer command prompt if VS150COMNTOOLS is not set. It's ugly and hardcoded too.
        for %%n in (Enterprise Professional Community BuildTools) do (
            set "p=%ProgramFiles(x86)%\Microsoft Visual Studio\2019\%%n\Common7\Tools\"
            if exist "!p!\VsDevCmd.bat" (
  
  It's best to leave windows decide where VS is installed rather than guessing (even if it's successful for 99% of the cases). I used to install software which required many GB to another partition since C: was tiny.
  
  About the message of the toolchain I think it's correct. Keep it simple ;) You might want to keep your changes as a backup and start over, but consult the devs too. Good luck!

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D21589

To: sredman, #kdevelop
Cc: Petross404, apol, kfunk, brauch, kdevelop-devel, christiant, glebaccon, domson, antismap, iodelay, alexeymin, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20190610/cc2e6948/attachment.html>