D22182: Remove anchorClicked lock which causes deadlock

Aaron Puchert noreply at phabricator.kde.org
Sat Jul 20 21:22:06 BST 2019


aaronpuchert added a comment.


  In D22182#495823 <https://phabricator.kde.org/D22182#495823>, @mswan wrote:
  
  > Also, in spite of what I said earlier, I think the explicit DUChain locking should be done and there eventually should be some work done to determine which objects will only interact with one specific DUChain per instance of that object, i.e.  an object that should reference a specific DUChain, e.g. ClangSupport. We could make the first pass at this involve replacing all of those `DUChainReadLocker lock;` lines with `DUChainReaderLocker lock(DUChain::lock());`, [...]
  
  
  By the way, I've started working on that, so you don't need to bother yourself doing that. When I have some annotations done I will have a look at this again and properly review your change.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D22182

To: mswan, #kdevelop
Cc: aaronpuchert, kdevelop-devel, hmitonneau, christiant, glebaccon, domson, antismap, iodelay, alexeymin, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20190720/f36039c2/attachment.html>


More information about the KDevelop-devel mailing list