D17908: kdevelop-msvc.bat finds VS-2017 based on a registry key on Windows.

[Milian Wolff]

mwolff requested changes to this revision.
mwolff added a comment.
This revision now requires changes to proceed.


  sorry for the long delay, it sounds like a good idea but the diff is super hard to review since it contains lots of unrelated whitespace changes

INLINE COMMENTS

> kdevelop-msvc.bat:8
>  IF NOT DEFINED VS150COMNTOOLS (
> -    REM load Visual Studio 2017 developer command prompt if VS150COMNTOOLS is not set. It's ugly and hardcoded too.
> -    for %%n in (Enterprise Professional Community BuildTools) do (
> -        set "p=%ProgramFiles(x86)%\Microsoft Visual Studio\2017\%%n\Common7\Tools\"
> -        if exist "!p!\VsDevCmd.bat" (
> -            set "VS150COMNTOOLS=!p!"
> -            goto :end
> -        )
> -    )
> +	REM load Visual Studio 2017 developer command prompt if VS150COMNTOOLS isn't set. Read Windows registry in case VS is not istalled on C:\
> +	for /f "usebackq tokens=3*" %%a in (`reg query "HKEY_LOCAL_MACHINE\SOFTWARE\Wow6432Node\Microsoft\VisualStudio\SxS\VS7" /s`) do (

could you please undo the whitespace changes and re-upload the minimal diff?

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D17908

To: Petross404, #kdevelop, kfunk, brauch, mwolff
Cc: mwolff, kdevelop-devel, glebaccon, hase, antismap, iodelay, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20190127/d1887539/attachment-0001.html>