D18224: Clang Plugin: Report some problems from included files

[Pino Toscano]

pino added inline comments.

INLINE COMMENTS

> parsesession.cpp:213
> +            QString description = ClangString(clang_getDiagnosticSpelling(childDiagnostic)).toString();
> +            if (description.endsWith(QLatin1String("requested here"))) {
> +                return true;

OOC, does clang support translations of its messages? if so, would this check be problematic?

> parsesession.cpp:251
> +            problem->setFinalLocation(subproblem->finalLocation());
> +            problem->setDescription(i18n("Requested here: ") + problem->description());
> +            foundRequestedHere = true;

no string puzzles please:
https://techbase.kde.org/Development/Tutorials/Localization/i18n_Mistakes#Pitfall_.232:_Word_Puzzles
so i18n("Requested here: %1", problem->description())

> parsesession.cpp:262
> +        problem->setFinalLocation(DocumentRange{indexedPath, problemRange});
> +        problem->setDescription(i18n("In included file: ") + problem->description());
> +    }

ditto

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D18224

To: thomassc, #kdevelop, mwolff
Cc: pino, mwolff, kdevelop-devel, glebaccon, hase, antismap, iodelay, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20190120/afd0600d/attachment-0001.html>