D15797: [kdev-clazy] : use canonical paths

[René J.V. Bertin]

rjvbb marked 2 inline comments as done.
rjvbb added inline comments.

INLINE COMMENTS

> mwolff wrote in jobparameters.cpp:168
> you can remove the previous check, since the second necessarily has to include it

I assume you meant the first component of the `||` expression?

> mwolff wrote in jobparameters.cpp:175
> we don't do this anywhere else - I'd suggest you always operate on canonical paths
> 
> note that you may want to pretty print paths before showing them to the user anyways. there's a function somewhere (Project?) that takes a path and turns it into a relative-to-project-root string ready for consumption by the user

Yes, that would be something like

  Core::self()->projectController()->prettyFileName(urlDoc->url(), KDevelop::IProjectController::FormatPlain);

(took me way longer than reasonable to remember where I might find it being used ...)

It seems though that this is already being done (`ProblemModel::reset()`), did I miss a place where that is not yet so?

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D15797

To: rjvbb, #kdevelop, antonanikin, mwolff
Cc: mwolff, antonanikin, kdevelop-devel, glebaccon, hase, antismap, iodelay, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20190117/d48b4570/attachment.html>