D5447: Only add auto-detected compilers to model if they actually exist

Aleix Pol Gonzalez noreply at phabricator.kde.org
Tue Jan 8 15:50:47 GMT 2019


apol added inline comments.

INLINE COMMENTS

> arrowd wrote in compilerprovider.cpp:214
> @apol You worked with runtime thingie more than me. What does this check do? Shouldn't it be `! QFileInfo::exists()`?

Sounds likely. It's being removed anyway here, right?

Actually this whole patch will break it because it's checking on the host system and not on the runtime.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D5447

To: arrowd, mwolff, kfunk, arichardson
Cc: skalinichev, apol, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20190108/bb3d2180/attachment.html>


More information about the KDevelop-devel mailing list