D5447: Only add auto-detected compilers to model if they actually exist
Gleb Popov
noreply at phabricator.kde.org
Sat Jan 5 09:11:06 GMT 2019
arrowd added inline comments.
INLINE COMMENTS
> compilerprovider.cpp:214
> - const bool absolutePath = QDir::isAbsolutePath(compiler->path());
> - if ((absolutePath && QFileInfo::exists(rt->pathInHost(Path(compiler->path())).toLocalFile()))
> - || QStandardPaths::findExecutable( compiler->path(), path).isEmpty() ) {
@apol You worked with runtime thingie more than me. What does this check do? Shouldn't it be `! QFileInfo::exists()`?
REPOSITORY
R32 KDevelop
REVISION DETAIL
https://phabricator.kde.org/D5447
To: arrowd, mwolff, kfunk, arichardson
Cc: skalinichev, apol, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20190105/392692f3/attachment-0001.html>
More information about the KDevelop-devel
mailing list