D17858: clang: Also detect Clang builtin dirs at runtime on Unix
Milian Wolff
noreply at phabricator.kde.org
Tue Jan 8 15:25:45 GMT 2019
mwolff requested changes to this revision.
mwolff added a comment.
+1 in general
INLINE COMMENTS
> clanghelpers.cpp:397
> + hardcodedDir.cd(QStringLiteral("../.."));
> + dir = QDir::cleanPath(QStringLiteral("%1/%2/include")
> + .arg(hardcodedDir.path(), clangVersion()));
does the following simplified code work as well?
auto dir = QDir(QStringLiteral(KDEV_CLANG_BUILTIN_DIR);
if (dir.cd(QStringLiteral("../../%1/include").arg(clangVersion()) {
clangDebug() << "Using builtin dir:" << dir.currentPath();
return dir.currentPath();
}
REPOSITORY
R32 KDevelop
REVISION DETAIL
https://phabricator.kde.org/D17858
To: rjvbb, #kdevelop, flherne, mwolff
Cc: mwolff, flherne, kdevelop-devel, glebaccon, hase, antismap, iodelay, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20190108/4cfe4b2a/attachment-0001.html>
More information about the KDevelop-devel
mailing list