D11934: KDevelop : "Reparse Entire Project" action in the project manager context menu

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Sun Feb 17 23:01:58 GMT 2019

kossebau added a comment.

  "Hi Friedirch, thanks for your pointer and the question. Though your quick post-commit read missed the fact that the new implementation of `openProjectConfig()`, while looking shorter, now reuses the new code introduced for the actual purpose of the commit. I am sorry that I missed to properly document this in the commit message that I not only added a new action, but also rewrote as side effect some existing otherwise unrelated code for the purpose of code reuse. I also understand that reasons for code changes should not be buried in long discussions on review boards, but be with the final code result, as no future code reader has time to find and rescan complete review discussions."

  R32 KDevelop


To: rjvbb, #kdevelop, mwolff
Cc: kossebau, mwolff, kdevelop-devel, gennad, glebaccon, antismap, iodelay, alexeymin, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20190217/4fee555f/attachment.html>

More information about the KDevelop-devel mailing list