D15625: Sublime: Fix crash caused when all tool view items are small

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Tue Sep 25 20:53:16 BST 2018

kossebau added a comment.

  In D15625#331810 <https://phabricator.kde.org/D15625#331810>, @rjvbb wrote:
  > >   I am slighty uneasy with the explosion of code we add now
  > Seems to me you're the one who asked for it ;)
  I did not ask for code explosion though. But as you can read by the next lines, I totally understand why the patches has been growing since (just that I now would like to see aspect solve differently, as it only fixes a trigger and does not prevent the general conceptually valid crash chance).
  > Does this add anything over the original patch + the fallback/catch-all, aside from a lot of extra code? I don't *see* any differences (in the UI behaviour).
  Yes, it makes the code more sane and complete and less fragile.  I did not see any crashes as well in the UI before, so by that argument this patch here would not have been necessary ;)

  R32 KDevelop



To: amhndu, #kdevelop, kossebau, rjvbb
Cc: kossebau, rjvbb, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180925/bc64be12/attachment.html>

More information about the KDevelop-devel mailing list