D15625: Sublime: Fix crash caused when all tool view items are small
René J.V. Bertin
noreply at phabricator.kde.org
Mon Sep 24 20:40:34 BST 2018
rjvbb accepted this revision.
rjvbb added a comment.
This revision is now accepted and ready to land.
Looks like you nailed it this time.
However, maximumWidth|Height can still be 0 when rect.width()|height() == buttonSpacing * (_items.size() - 1) (and given the values I've seen that doesn't seem outlandish). And that's not even a requirement; if all items have 0 width or height you will still end up without any small items.
In other words, maybe you shouldn't justify the fallback with potential "latent miscalculations" but simply with the observation that you cannot guarantee that there will be at least 1 large item.
To: amhndu, #kdevelop, kossebau, rjvbb
Cc: kossebau, rjvbb, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel