D15694: Make implicit fallthroughs a compiler error, remove unneeded breaks

[Aaron Puchert]

aaronpuchert updated this revision to Diff 42194.
aaronpuchert marked an inline comment as done.
aaronpuchert added a comment.


  Remove comment in plugins/ghprovider/ghproviderwidget.cpp, as the fallthrough is probably intended, and add break in plugins/qmljs/codecompletion/context.cpp, as it is probably not intended. Now the code completion doesn't suggest variables of the same type as the last parameter in functions calls, which seems about right.

REPOSITORY
  R32 KDevelop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15694?vs=42139&id=42194

BRANCH
  cleanup-switch-statements

REVISION DETAIL
  https://phabricator.kde.org/D15694

AFFECTED FILES
  CMakeLists.txt
  kdevplatform/language/codecompletion/normaldeclarationcompletionitem.cpp
  kdevplatform/language/duchain/navigation/abstractnavigationcontext.cpp
  kdevplatform/language/duchain/stringhelpers.cpp
  kdevplatform/outputview/outputmodel.cpp
  kdevplatform/project/projectbuildsetmodel.cpp
  kdevplatform/shell/sessionlock.cpp
  kdevplatform/vcs/vcsrevision.cpp
  plugins/clang/duchain/clangdiagnosticevaluator.cpp
  plugins/clang/duchain/clangproblem.cpp
  plugins/custom-definesandincludes/kcm_widget/projectpathsmodel.cpp
  plugins/ghprovider/ghproviderwidget.cpp
  plugins/makebuilder/makejob.cpp
  plugins/perforce/perforceplugin.cpp
  plugins/qmljs/codecompletion/context.cpp

To: aaronpuchert, #kdevelop
Cc: brauch, mssola, kossebau, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180923/abb5a1fc/attachment.html>