<table><tr><td style="">aaronpuchert updated this revision to Diff 42194.<br />aaronpuchert marked an inline comment as done.<br />aaronpuchert added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D15694">View Revision</a></tr></table><br /><div><div><p>Remove comment in plugins/ghprovider/ghproviderwidget.cpp, as the fallthrough is probably intended, and add break in plugins/qmljs/codecompletion/context.cpp, as it is probably not intended. Now the code completion doesn't suggest variables of the same type as the last parameter in functions calls, which seems about right.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D15694?vs=42139&id=42194">https://phabricator.kde.org/D15694?vs=42139&id=42194</a></div></div><br /><div><strong>BRANCH</strong><div><div>cleanup-switch-statements</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D15694">https://phabricator.kde.org/D15694</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>CMakeLists.txt<br />
kdevplatform/language/codecompletion/normaldeclarationcompletionitem.cpp<br />
kdevplatform/language/duchain/navigation/abstractnavigationcontext.cpp<br />
kdevplatform/language/duchain/stringhelpers.cpp<br />
kdevplatform/outputview/outputmodel.cpp<br />
kdevplatform/project/projectbuildsetmodel.cpp<br />
kdevplatform/shell/sessionlock.cpp<br />
kdevplatform/vcs/vcsrevision.cpp<br />
plugins/clang/duchain/clangdiagnosticevaluator.cpp<br />
plugins/clang/duchain/clangproblem.cpp<br />
plugins/custom-definesandincludes/kcm_widget/projectpathsmodel.cpp<br />
plugins/ghprovider/ghproviderwidget.cpp<br />
plugins/makebuilder/makejob.cpp<br />
plugins/perforce/perforceplugin.cpp<br />
plugins/qmljs/codecompletion/context.cpp</div></div></div><br /><div><strong>To: </strong>aaronpuchert, KDevelop<br /><strong>Cc: </strong>brauch, mssola, kossebau, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd<br /></div>