D15530: kdev-clang : somewhat more complete ObjC(++) support

Aaron Puchert noreply at phabricator.kde.org
Fri Sep 21 22:49:23 BST 2018


aaronpuchert added a comment.


  In D15530#329377 <https://phabricator.kde.org/D15530#329377>, @rjvbb wrote:
  
  > > You should probably also add a few lines to the `custom-definesandincludes` plugin.
  >
  > In a different review I presume?
  
  
  Of course, keep changes small.

INLINE COMMENTS

> rjvbb wrote in parsesession.cpp:137-141
> Maybe as a separate, later change, or is there already a state or language variable that is suitable an argument for a switch statement?

Thanks, that's exactly what I meant. It doesn't literally have to be a switch statement. (Although it would be a nice refactoring to add an enumeration later.)

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D15530

To: rjvbb, #kdevelop
Cc: aaronpuchert, kossebau, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180921/ef75f309/attachment.html>


More information about the KDevelop-devel mailing list