D8709: Add VcsAnnotationItemDelegate, for control of rendering and tooltip

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D8709#326162 <https://phabricator.kde.org/D8709#326162>, @croick wrote:
  
  > I like it so far. The additional information is certainly helpful when trying to understand the history of some piece of code.
  
  
  Thanks for testing :)
  
  > - The behaviour of the ToolTip is better now. However, if the commit message is too short, it's sometimes not possible to reach "Select All" in the context menu of the ToolTip. But that's rather an issue with the `ActiveToolTip` vanishing immediatly once it's left.
  
  Yes, seen that as well. Not yet sure what to do here.
  
  > - If I try to "Show Diff..." of any annotation, KDevelop will crash:
  
  Eek, I will have a look tomorrow, never experienced that.

INLINE COMMENTS

> croick wrote in vcsannotationitemdelegate.cpp:388
> On a small screen, that's taking a little too much space in my opinion. I preferred 20%.
> 
> What would be necessary to make it resizable?

Myself I would actually prefer 30 % :) Guess that should be a value users want to customize in the general kdevelop settings. Will extend the patch to propose to add that.

For making it interactively resizeable, that will need some extension of KateView in KTextEditor. Have not yet thought further about this and how it should be as user experience and how it could be implemented

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D8709

To: kossebau, kfunk
Cc: croick, kfunk, brauch, apol, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180915/c9af3453/attachment.html>