D8709: Add VcsAnnotationItemDelegate, for control of rendering and tooltip

[Christoph Roick]

croick added a comment.


  I like it so far. The additional information is certainly helpful when trying to understand the history of some piece of code.
  
  - The behaviour of the ToolTip is better now. However, if the commit message is too short, it's sometimes not possible to reach "Select All" in the context menu of the ToolTip. But that's rather an issue with the `ActiveToolTip` vanishing immediatly once it's left.
  
  - If I try to "Show Diff..." of any annotation, KDevelop will crash:
  
    #6  0x00007f1e74ff3d37 in KTextEditor::ViewPrivate::uniformAnnotationItemSizes() const (this=0x562425e5c750) at /home/christoph/Software/kde/frameworks/ktexteditor/src/view/kateviewhelpers.h:299
    #7  0x00007f1e75016b63 in KateIconBorder::calcAnnotationBorderWidth() (this=this at entry=0x56242e3eb9f0) at /home/christoph/Software/kde/frameworks/ktexteditor/src/view/kateviewhelpers.cpp:2722
    #8  0x00007f1e75016ca0 in KateIconBorder::updateFont() (this=0x56242e3eb9f0) at /home/christoph/Software/kde/frameworks/ktexteditor/src/view/kateviewhelpers.cpp:1631
    #9  0x00007f1e7501b092 in KateIconBorder::KateIconBorder(KateViewInternal*, QWidget*) (this=0x56242e3eb9f0, internalView=<optimized out>, parent=<optimized out>) at /home/christoph/Software/kde/frameworks/ktexteditor/src/view/kateviewhelpers.cpp:1458
    #10 0x00007f1e75005f00 in KateViewInternal::KateViewInternal(KTextEditor::ViewPrivate*) (this=0x56242a732190, view=<optimized out>) at /home/christoph/Software/kde/frameworks/ktexteditor/src/view/kateviewinternal.cpp:233
    #11 0x00007f1e74ffe904 in KTextEditor::ViewPrivate::ViewPrivate(KTextEditor::DocumentPrivate*, QWidget*, KTextEditor::MainWindow*) (this=0x562425e5c750, doc=0x562424247cc0, parent=<optimized out>, mainWindow=0x562423ba63f0) at /home/christoph/Software/kde/frameworks/ktexteditor/src/document/katedocument.h:1049
    #12 0x00007f1e74f77f58 in KTextEditor::DocumentPrivate::createView(QWidget*, KTextEditor::MainWindow*) (this=this at entry=0x562424247cc0, parent=parent at entry=0x56242dc32310, mainWindow=0x562423ba63f0) at /home/christoph/Software/kde/frameworks/ktexteditor/src/document/katedocument.cpp:417
    #13 0x00007f1e764f5207 in KDevelop::TextDocument::createViewWidget(QWidget*) (this=0x5624259b14c0, parent=0x56242dc32310) at /usr/include/c++/8.2.1/bits/atomic_base.h:390
    #14 0x00007f1e764f4225 in KDevelop::TextView::createWidget(QWidget*) (this=0x56242635b410, parent=0x56242dc32310) at /home/christoph/Software/kde/extragear/kdevelop/kdevelop/kdevplatform/shell/textdocument.cpp:565

INLINE COMMENTS

> vcsannotationitemdelegate.cpp:388
> +    // Ideally the user could configure the width of the annotations, best interactively.
> +    // Until this is possible, the sizehint is: roughly 40 chars, but maximal 25 % of the view
> +    // See eventFilter for making sure we adapt the max 25 % to a changed width.

On a small screen, that's taking a little too much space in my opinion. I preferred 20%.

What would be necessary to make it resizable?

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D8709

To: kossebau, kfunk
Cc: croick, kfunk, brauch, apol, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180914/abd83961/attachment.html>