D14618: Create action to jump to the current execution line in debug mode.

[Friedrich W. H. Kossebau]

kossebau added a comment.


  This one has not yet landed, right?
  
  @amhndu  Given you are coming with all the good patches, please consider applying for contributor account, so you can land your patches yourself :) See https://community.kde.org/Infrastructure/Get_a_Developer_Account for instructions.

INLINE COMMENTS

> debugcontroller.cpp:557
> +{
> +    auto location = qMakePair(m_currentSession->currentUrl(), m_currentSession->currentLine());
> +

const auto location, please

> debugcontroller.cpp:559
> +
> +    if (location.second != -1)
> +    {

{ on same line as the if, please

> debugcontroller.cpp:561
> +    {
> +        QPair<QUrl, int> localLocation = m_currentSession->convertToLocalUrl(location);
> +        ICore::self()->documentController()->openDocument(localLocation.first,

const auto localLocation, please (auto for consistency with above)

REPOSITORY
  R32 KDevelop

BRANCH
  show-execution

REVISION DETAIL
  https://phabricator.kde.org/D14618

To: amhndu, #kdevelop, brauch
Cc: kossebau, brauch, kdevelop-devel, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180913/6761723c/attachment.html>