<table><tr><td style="">kossebau added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14618">View Revision</a></tr></table><br /><div><div><p>This one has not yet landed, right?</p>
<p><a href="https://phabricator.kde.org/p/amhndu/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@amhndu</a> Given you are coming with all the good patches, please consider applying for contributor account, so you can land your patches yourself :) See <a href="https://community.kde.org/Infrastructure/Get_a_Developer_Account" class="remarkup-link" target="_blank" rel="noreferrer">https://community.kde.org/Infrastructure/Get_a_Developer_Account</a> for instructions.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14618#inline-83282">View Inline</a><span style="color: #4b4d51; font-weight: bold;">debugcontroller.cpp:557</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">auto</span> <span class="n">location</span> <span style="color: #aa2211">=</span> <span class="n">qMakePair</span><span class="p">(</span><span class="n">m_currentSession</span><span style="color: #aa2211">-></span><span class="n">currentUrl</span><span class="p">(),</span> <span class="n">m_currentSession</span><span style="color: #aa2211">-></span><span class="n">currentLine</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">const auto location, please</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14618#inline-83281">View Inline</a><span style="color: #4b4d51; font-weight: bold;">debugcontroller.cpp:559</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">location</span><span class="p">.</span><span class="n">second</span> <span style="color: #aa2211">!=</span> <span style="color: #aa2211">-</span><span style="color: #601200">1</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">{ on same line as the if, please</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14618#inline-83283">View Inline</a><span style="color: #4b4d51; font-weight: bold;">debugcontroller.cpp:561</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QPair</span><span style="color: #aa2211"><</span><span class="n">QUrl</span><span class="p">,</span> <span style="color: #aa4000">int</span><span style="color: #aa2211">></span> <span class="n">localLocation</span> <span style="color: #aa2211">=</span> <span class="n">m_currentSession</span><span style="color: #aa2211">-></span><span class="n">convertToLocalUrl</span><span class="p">(</span><span class="n">location</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">ICore</span><span style="color: #aa2211">::</span><span class="n">self</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">documentController</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">openDocument</span><span class="p">(</span><span class="n">localLocation</span><span class="p">.</span><span class="n">first</span><span class="p">,</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">const auto localLocation, please (auto for consistency with above)</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>BRANCH</strong><div><div>show-execution</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D14618">https://phabricator.kde.org/D14618</a></div></div><br /><div><strong>To: </strong>amhndu, KDevelop, brauch<br /><strong>Cc: </strong>kossebau, brauch, kdevelop-devel, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd<br /></div>