D8709: [WIP] Add VcsAnnotationItemDelegate, for control of rendering, menus and tooltip

Aleix Pol Gonzalez noreply at phabricator.kde.org
Tue Sep 4 17:58:05 BST 2018


apol added inline comments.

INLINE COMMENTS

> brauch wrote in CMakeLists.txt:48
> Sorry Aleix, I'm strongly against this. Requiring KF5 5.40 effectively means nobody using ubuntu will be able to self-compile KDevelop easily before mid-next-year, it means we have to rebuild our windows dependency chain (which in the past always turned out to be at least a day's worth of fiddling), and so on. It's simply not worth it. Let's keep the ifdef and wait for more things depending on later KF5 to come up before we bump the requirement.

xD in fairness, v5.40.0 nowadays is older than the last Ubuntu LTS release and it should be fine to have it included there unconditionally.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D8709

To: kossebau, kfunk
Cc: kfunk, brauch, apol, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180904/bd19aa73/attachment.html>


More information about the KDevelop-devel mailing list