D8709: [WIP] Add VcsAnnotationItemDelegate, for control of rendering, menus and tooltip

[Kevin Funk]

kfunk requested changes to this revision.
kfunk added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> brauch wrote in CMakeLists.txt:48
> Sorry Aleix, I'm strongly against this. Requiring KF5 5.40 effectively means nobody using ubuntu will be able to self-compile KDevelop easily before mid-next-year, it means we have to rebuild our windows dependency chain (which in the past always turned out to be at least a day's worth of fiddling), and so on. It's simply not worth it. Let's keep the ifdef and wait for more things depending on later KF5 to come up before we bump the requirement.

+1 on Sven's remarks.

@kossebau Why's that still commented?

> vcspluginhelper.cpp:399
>              annotateiface->setAnnotationModel(model);
> +#ifdef USE_ANNOTATIONITEMDELEGATE
> +            KTextEditor::AnnotationViewInterfaceV2* viewifaceV2 = qobject_cast<KTextEditor::AnnotationViewInterfaceV2*>(view);

Or simply:

  #if KTEXTEDITOR_VERSION > QT_VERSION_CHECK(5,40,0)
  ...

in this file. /me doesn't like `#ifdef`s, `#if`s are easier to track since you're getting compiler warnings when the define gets lost for whatever reason.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D8709

To: kossebau, kfunk
Cc: kfunk, brauch, apol, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180904/c3d05377/attachment.html>