D16203: Context browser: fix handleRect for non-symbol tooltips

Sven Brauch noreply at phabricator.kde.org
Wed Oct 17 17:47:43 BST 2018


brauch added a comment.


  I'm not a huge fan of tuples either, for the reason you mentioned; I usually just create a two-element struct instead. In this case I think it's fairly obvious what the elements do from the types, though; the QPair<int, int> is worse ;)
  Up to you how you do this, I just wanted to point out that it is done differently in two similar places.
  
  Looks ok to me, if Kevin doesn't have objections to putting this into 1.3, go ahead ;)
  
  Thank you for your work!

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D16203

To: kossebau, #kdevelop
Cc: brauch, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20181017/532e6b0d/attachment.html>


More information about the KDevelop-devel mailing list