D16203: Context browser: fix handleRect for non-symbol tooltips

[Friedrich W. H. Kossebau]

kossebau marked an inline comment as done.
kossebau added inline comments.

INLINE COMMENTS

> brauch wrote in contextbrowser.cpp:556
> In the API, you return a tuple for this use case, here you use a return argument instead. I think you should return a tuple here as well.

Proposed to do that in the public API to follow the rest of the methods there.

Personally not yet a fan of tuples, at least the QPair ones with their semantically poor `first` and `second` member names, so avoided to do that here. But given you asked, I tried a variant using also QPair for this method here, not sure I prefer it.

Updating the patch next with that to give you an idea and something to choose from :)

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D16203

To: kossebau, #kdevelop
Cc: brauch, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20181017/8353e31d/attachment-0001.html>