D15976: Fix KDevelop's detection for Visual Studio 2017 compiler and tools.

Petros Siligkounas noreply at phabricator.kde.org
Tue Oct 9 20:55:15 BST 2018


Petross404 updated this revision to Diff 43248.
Petross404 added a comment.


  Our script now initializes the environment correctly (at least for VS2017) even if the user doesn't run it from `Developers Command Prompt`. It reads Registry to find the path under which VS2017 is installed (I fear that I read the wrong `variable` from the Registry).
  
  The script asks for the architecture when it's ran by clicking but it doesn't when it's ran from `DCP`. I didn't want to add more lines.
  
  When `kdevelop-msvc.bat` is dealing with VS2017 //and //`VS150COMNTOOLS` defined //or// older VS versions, it makes use of the `script` variable, while when dealing with VS2017 without `VS150COMNTOOLS` defined (i.e. `kdevelop-msvc.bat` was clicked) it reads the Registry and asks for architecture.

REPOSITORY
  R32 KDevelop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15976?vs=43178&id=43248

REVISION DETAIL
  https://phabricator.kde.org/D15976

AFFECTED FILES
  app/windows/kdevelop-msvc.bat

To: Petross404, #kdevelop, kfunk
Cc: kfunk, arrowd, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20181009/7b110eb4/attachment.html>


More information about the KDevelop-devel mailing list