D16085: Improve support for 'with' statements.

[Sven Brauch]

brauch accepted this revision.
brauch added a comment.
This revision is now accepted and ready to land.


  Otherwise looks good! If you feel super ambitious you could add a test, should be very simple ;)

INLINE COMMENTS

> declarationbuilder.cpp:376
> +                                                                )) {
> +            enterType = enterFunc->type<FunctionType>()->returnType();
> +        }

Please check whether the type assigned to this function is indeed a FunctionType, yes it should be, but it happens sometimes that other code screws this up and then this will crash

REPOSITORY
  R53 KDevelop: Python Support

REVISION DETAIL
  https://phabricator.kde.org/D16085

To: flherne, brauch, nalvarez
Cc: kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20181009/66a104fc/attachment-0001.html>