D16064: Fix memleaks in unittests

Bernd Buschinski noreply at phabricator.kde.org
Tue Oct 9 10:04:10 BST 2018


buschinski created this revision.
buschinski added a reviewer: KDevelop.
Herald added a project: KDevelop.
Herald added a subscriber: kdevelop-devel.
buschinski requested review of this revision.

REVISION SUMMARY
  Fix memory leaks in unittests to make it easier to find real memory leaks in the tested code.
  
  Fixed tests:
  
  - test_projectmodel
  - test_areaoperation
  - test_controller
  - test_toolviewtoolbar
  - test_viewactivation
  
  NOTE: this does not fix all memory leaks in all unittests, this is just s start to keep the changes small

TEST PLAN
  - cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON ..
  - make test
  
  Many tests will fail because of LSAN (leak sanitizer), which is enabled (at least here) by default with ASAN.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D16064

AFFECTED FILES
  kdevplatform/project/tests/test_projectmodel.cpp
  kdevplatform/sublime/tests/test_areaoperation.cpp
  kdevplatform/sublime/tests/test_controller.cpp
  kdevplatform/sublime/tests/test_toolviewtoolbar.cpp
  kdevplatform/sublime/tests/test_viewactivation.cpp

To: buschinski, #kdevelop
Cc: kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20181009/dc9f1b23/attachment-0001.html>


More information about the KDevelop-devel mailing list