D15977: Generate kdebugsettings .categories file automatically

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Thanks for review,

INLINE COMMENTS

> kfunk wrote in KDevelopMacrosInternal.cmake:101
> Would be careful with the custom target name, could easily create a name conflict.
> 
> Maybe prefixed the target name with `qt_logging_category_` or sth?
> 
>   set(_target "qt_logging_category_${ARGS_EXPORT}"
>   ...

Good idea, will do.

> kfunk wrote in KDevelopMacrosInternal.cmake:141
> Minor: You can split strings across multiple lines in CMake: https://stackoverflow.com/a/27983206/592636

Yes, known. I am undecided which is the more ugly/easy to understand variant when it comes to seeing whether linebreaks will be added.
If you prefer implicit linebreaks, will do.

> kfunk wrote in KDevelopMacrosInternal.cmake:147
> Looks like the KDebugSettings format was extended a little bit, in the meantime?
> 
> https://lxr.kde.org/source/kde/kdeutils/kdebugsettings/data/kde.categories
> 
> Is there something we can use as well? (Doesn't need to part of this patch, though)

Yes. Sadly the extension was done without backward compatibility. And relying on apps using that being part of kde applications as well, thus the version dependency to kdebugsettings is resolved by packaging of KA. No idea yet how to find out which version of kdebugsettings can be expected at runtime.
See also https://bugs.kde.org/show_bug.cgi?id=396959 where I failed to make the author motivated to fix the missing backwards compatibility.

REPOSITORY
  R32 KDevelop

BRANCH
  generatecategoriesfile

REVISION DETAIL
  https://phabricator.kde.org/D15977

To: kossebau, #kdevelop, kfunk
Cc: kfunk, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20181007/eea02a1c/attachment.html>