<table><tr><td style="">kossebau added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D15977">View Revision</a></tr></table><br /><div><div><p>Thanks for review,</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15977#inline-86798">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kfunk</span> wrote in <span style="color: #4b4d51; font-weight: bold;">KDevelopMacrosInternal.cmake:101</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Would be careful with the custom target name, could easily create a name conflict.</p>
<p style="padding: 0; margin: 8px;">Maybe prefixed the target name with <tt style="background: #ebebeb; font-size: 13px;">qt_logging_category_</tt> or sth?</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">set(_target "qt_logging_category_${ARGS_EXPORT}"
...</pre></div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Good idea, will do.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15977#inline-86801">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kfunk</span> wrote in <span style="color: #4b4d51; font-weight: bold;">KDevelopMacrosInternal.cmake:141</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Minor: You can split strings across multiple lines in CMake: <a href="https://stackoverflow.com/a/27983206/592636" class="remarkup-link" target="_blank" rel="noreferrer">https://stackoverflow.com/a/27983206/592636</a></p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Yes, known. I am undecided which is the more ugly/easy to understand variant when it comes to seeing whether linebreaks will be added.<br />
If you prefer implicit linebreaks, will do.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15977#inline-86802">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kfunk</span> wrote in <span style="color: #4b4d51; font-weight: bold;">KDevelopMacrosInternal.cmake:147</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Looks like the KDebugSettings format was extended a little bit, in the meantime?</p>
<p style="padding: 0; margin: 8px;"><a href="https://lxr.kde.org/source/kde/kdeutils/kdebugsettings/data/kde.categories" class="remarkup-link" target="_blank" rel="noreferrer">https://lxr.kde.org/source/kde/kdeutils/kdebugsettings/data/kde.categories</a></p>
<p style="padding: 0; margin: 8px;">Is there something we can use as well? (Doesn't need to part of this patch, though)</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Yes. Sadly the extension was done without backward compatibility. And relying on apps using that being part of kde applications as well, thus the version dependency to kdebugsettings is resolved by packaging of KA. No idea yet how to find out which version of kdebugsettings can be expected at runtime.<br />
See also <a href="https://bugs.kde.org/show_bug.cgi?id=396959" class="remarkup-link" target="_blank" rel="noreferrer">https://bugs.kde.org/show_bug.cgi?id=396959</a> where I failed to make the author motivated to fix the missing backwards compatibility.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>BRANCH</strong><div><div>generatecategoriesfile</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D15977">https://phabricator.kde.org/D15977</a></div></div><br /><div><strong>To: </strong>kossebau, KDevelop, kfunk<br /><strong>Cc: </strong>kfunk, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd<br /></div>