D15911: cmake: fix detecting ids with digits inside on a cursor position

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Wed Oct 3 00:35:08 BST 2018


kossebau created this revision.
kossebau added reviewers: KDevelop, apol.
Herald added a project: KDevelop.
Herald added a subscriber: kdevelop-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  CMakeManager::specialLanguageObjectNavigationWidget() implementation was
  only checking for letters and _, thus not properly detecting ids with digits
  inside, e.g. the CMPxxxx policy ids.

TEST PLAN
  Hovering over "CMP0071" in a CMakeLists.txt or presseing Alt now triggers
  the navigation widget with the respective documentation.
  Doing the same for CMake functions and variables still works as before

REPOSITORY
  R32 KDevelop

BRANCH
  improvecmakeidhoverdetection

REVISION DETAIL
  https://phabricator.kde.org/D15911

AFFECTED FILES
  plugins/cmake/cmakemanager.cpp
  plugins/cmake/cmakemanager.h

To: kossebau, #kdevelop, apol
Cc: kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20181002/ab5d6bbd/attachment.html>


More information about the KDevelop-devel mailing list