D17255: KDevelop: support for installing into a non-standard parallel prefix

[Kevin Funk]

kfunk added inline comments.

INLINE COMMENTS

> cmakeutils.cpp:326
>  {
> -    auto cmake = QStandardPaths::findExecutable(QStringLiteral("cmake"));
> +    auto cmake = QStandardPaths::findExecutable(QStringLiteral("cmake"), QStringList(QStringLiteral(KDEVELOP_INSTALL_PREFIX"/bin")));
> +    if (cmake.isEmpty()) {

This is also cumbersome, it would make sense in case CMake is shipped (or bundled with) KDevelop, but it isn't.

> cmakeutils.cpp:337
>              QStringLiteral("C:\\Program Files\\CMake 2.8\\bin")});
>  #endif
>      return cmake;

I'd be fine with a fallback:

  #elif Q_OS_MAC
  if (cmake.isEmpty())
      cmake = QStandardPaths::findExecutable(QStringLiteral("cmake"), {"/opt/local/bin"}) // for CMake from MacPorts

... here, though.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D17255

To: rjvbb, #kdevelop, kfunk
Cc: kfunk, kdevelop-devel, glebaccon, hase, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20181130/ca330b77/attachment.html>