D17168: Removes a crash related to include method
Aleix Pol Gonzalez
noreply at phabricator.kde.org
Mon Nov 26 12:37:01 GMT 2018
apol added inline comments.
INLINE COMMENTS
> usebuilder.cpp:90
> UseBuilderBase::newUse(m_editor->findRange(n), d);
> - ev.setContext(d->internalContext());
> + // TODO: is this context useful for something actually? If it is, I guess we need to create it.
> + auto context = d->internalContext();
This doesn't look like a to do item. The context should already be created anyway.
> usebuilder.cpp:95
> + if(context) {
> + Q_ASSERT(context);
> + ev.setContext(context);
assert after if doesn't make any sense.
REPOSITORY
R58 KDevelop Ruby
REVISION DETAIL
https://phabricator.kde.org/D17168
To: Smar
Cc: apol, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20181126/fe8ddd4f/attachment.html>
More information about the KDevelop-devel
mailing list