D16942: CMakeCacheModel: avoid string memory duplication

Rolf Eike Beer noreply at phabricator.kde.org
Sun Nov 18 20:09:55 GMT 2018


dakon added inline comments.

INLINE COMMENTS

> mwolff wrote in cmakecachemodel.cpp:76
> would be easier to just write
> 
>   currentComment += line.midRef(2);

Since "line" itself goes away after this loop there isn't anything to ref anymore, and I honestly don't know if this will work then. currentComment is a QStringList, no QString.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D16942

To: dakon, brauch
Cc: mwolff, brauch, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20181118/40ace8f6/attachment.html>


More information about the KDevelop-devel mailing list